KhronosGroup / KhronosGroup/Vulkan-Tutorial

Is the RenderGraph example code reversing execution order?

Open
#362 1 comment 0 reactions 0 assignees View on GitHub
Game Engine
Dominant language
C++
Stars
418
Forks
126
Avg merge
11d 6h
Merged PRs (30d)
31

Description

In this page:
https://docs.vulkan.org/tutorial/latest/Building_a_Simple_Engine/Engine_Architecture/05_rendering_pipeline.html#_rendergraph_dependency_analysis_and_execution_ordering

It's doing
```
for (auto dependent : dependents[node]) {
visit(dependent);
}
```

However doesn't that mean that the dependents will be executed first, before the pass that they depend on has executed. Shouldn't this be looping on `dependencies`?

Contributor guide

Open the contributing guide

Research direction

Read the RenderGraph dependency analysis and execution ordering section at the linked documentation page, focusing on the shown loop over dependents. Trace the dependency direction and execution-order explanation to determine whether the example is reversed; done means the code and accompanying text consistently describe the correct ordering.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
computer-graphics, documentation
Issue type
Documentation
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.