KhronosGroup / KhronosGroup/Vulkan-Tutorial

Compute chapter still uses fences

Open
#130 0 comments 0 reactions 1 assignee Claimed by @SaschaWillems View on GitHub
Dominant language
C++
Stars
418
Forks
126
Avg merge
11d 6h
Merged PRs (30d)
31

Description

Just noticed that while the reworked tutorial made the compute chapter use timeline semaphores it's still using fences to wait on the host side. But timeline semaphores can replace that, and so we should do that in the tutorial.

This is what I do in my code to replace fences with timeline semaphores:

```cpp
VkSemaphoreWaitInfo semaphoreWaitInfo{ .sType = VK_STRUCTURE_TYPE_SEMAPHORE_WAIT_INFO };
semaphoreWaitInfo.semaphoreCount = 1;
semaphoreWaitInfo.pSemaphores = &timeLineSemaphore.handle;
semaphoreWaitInfo.pValues = &timeLineSemaphore.value;
vkWaitSemaphoresKHR(device, &semaphoreWaitInfo, UINT64_MAX);
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.