KhronosGroup / KhronosGroup/Vulkan-Tools

Command line arguments --text, --json and --html output to file is inconsistant

Open
#1,101 2 comments 0 reactions 1 assignee Claimed by @charles-lunarg View on GitHub
bug vulkaninfo
Dominant language
C++
Stars
491
Forks
202
Avg merge
1h 37m
Merged PRs (30d)
4

Description

vulkaninfo has a [-o , --output ] argument, which is great. I would expect that when this argument is used, the log is outputted into a file, otherwise it's outputted to `stdout`.

**text mode**
However, outputting to `stdout` is only happening when vulkaninfo is called using:
`vulkaninfo` or
`vulkaninfo --text`

If using `vulkaninfo --text -o` I got the help to be displayed which match the `--help` but I think the filename could be optional.

**json mode**
When using:
`vulkaninfo --json`
The vulkaninfo log is automatically written into a filename that express what GPU it matched, eg: `VP_VULKANINFO_NVIDIA_GeForce_RTX_3080_Ti_553_22_0_0.json`.

However, I think `vulkaninfo --json` should output to `stdout` instead to match the --text behavior and `-o` should be used to output to a generated name file.

**html mode**
When using:
`vulkaninfo --html`
The vulkaninfo log is automatically written into `vulkaninfo.html`

However, I think `vulkaninfo --html` should output to `stdout` instead to match the --text behavior and `-o` should be used to output to a generated name file.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.