KhronosGroup / KhronosGroup/Vulkan-Samples

ComputeNbody sample - compute.uniform_buffer looks not properly synchronized, it's updated right after QueueSubmit.

Open
#1,094 3 comments 0 reactions 1 assignee Claimed by @SaschaWillems View on GitHub
Dominant language
C++
Stars
5.4k
Forks
835
Avg merge
2h 16m
Merged PRs (30d)
1

Description

Please look at ComputeNBody::render and ComputeNBody::draw.
We add an WaitForIdle in Api::VulkanSample::submit_frame(), so:
For graphics sequence, it's QueueSubmit -> WaitForIdle -> graphics.uniform_buffer.update. Most samples implement similar to this.
For compute sequence, it's QueueSubmit -> compute.uniform_buffer.update, there's no synchronization between the submission and buffer-update, which I think is wrong.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.