KhronosGroup / KhronosGroup/Vulkan-Loader
terminator_DestroySurfaceKHR aborts in assert when ICD does not support VK_KHR_surface
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 696
- Forks
- 343
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 17
Description
For an ICD without support for VK_KHR_surface the surface list pointer will be null. If vkDestroySurface is called terminator_DestroySurfaceKHR will abort in this assert:
assert((VkSurfaceKHR)(uintptr_t)NULL == icd_term->surface_list.list[icd_surface->surface_index]);
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at terminator_DestroySurfaceKHR and inspect the assertion involving icd_term->surface_list.list[icd_surface->surface_index] when the ICD lacks VK_KHR_surface support. Reproduce the call with such an ICD and verify that destroying the surface no longer aborts; add or update the relevant regression coverage if the repository identifies it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- computer-graphics
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100