KhronosGroup / KhronosGroup/Vulkan-Hpp
`Modules`: Don't include headers in module declaration
- Dominant language
- C++
- Stars
- 3.8k
- Forks
- 374
- Avg merge
- 23h 4m
- Merged PRs (30d)
- 32
Description
```
[build] ../vulkan.cppm:64:10: warning: '#include ' attaches the declarations to the named module 'vulkan', which is not usually intended; consider moving that directive before the module declaration
```
I get this warning when building the vulkan module. I don't understand what was wrong with just specifying the exported types directly inside `cppm`, why does it need to go through the headers now.
To me it seems like the vulkan module implementation is getting worse and worse.
Contributor guide
Research direction
Start with vulkan.cppm around line 64 and reproduce the reported build warning to understand how the header include relates to the module declaration. Compare this with the earlier approach of specifying exported types directly in cppm; done means the module no longer emits the warning about attaching included declarations to the named module.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- api
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Needs clarification
- Newbie friendliness
- 48/100