KhronosGroup / KhronosGroup/Vulkan-Docs

Incorrect VUIDs for `VkWriteDescriptorSet` used with `vkCmdPushDescriptorSetKHR`

Open
#1,673 4 comments 0 reactions 1 assignee View on GitHub

@spencer-lunarg is already working on this.

Since Jan 12, 2023.

Validity
Dominant language
JavaScript
Stars
3.3k
Forks
549
Avg merge
5d 5h
Merged PRs (30d)
2

Description

VUID-VkWriteDescriptorSet-descriptorType-02752 states:

If descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER, then dstSet must not have been allocated with a layout that included immutable samplers for dstBinding

This is correct for vkUpdateDescriptorSets, but not for vkCmdPushDescriptorSetKHR. For push descriptors, dstSet is ignored, and you are in fact required to use a descriptorType of VK_DESCRIPTOR_TYPE_SAMPLER when there are immutable samplers. There are also other VUIDs for VkWriteDescriptorSet that mention dstSet but don't qualify that it applies for vkUpdateDescriptorSets only.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.