KhronosGroup / KhronosGroup/ToneMapping

In light-filled scenes, objects appear as coloured contours in Khronos PBR Neutral

Open
#5 5 comments 1 reaction 0 assignees View on GitHub
documentation
Dominant language
JavaScript
Stars
113
Forks
11
PR merge metrics
No merged PRs in 30d

Description

Hi, I implemented several tone mappings, including Khronos PBR Neutral, in my own web3D library.
I was comparing and evaluating them and found that Khronos PBR Neutral showed distinctive results in certain scenes.

In light-filled scenes, only with Khronos PBR Neutral do objects appear as distinctive coloured contours and stand out in the white light.

![image](https://github.com/KhronosGroup/ToneMapping/assets/3821214/8506e98f-cec6-4e23-bb9a-4701f2dd1dee)
![image](https://github.com/KhronosGroup/ToneMapping/assets/3821214/76a7dea7-f5d5-4e86-ac5f-16b833d1a710)
![image](https://github.com/KhronosGroup/ToneMapping/assets/3821214/1d03325e-a168-41d3-a13f-0d6926529dcb)
![image](https://github.com/KhronosGroup/ToneMapping/assets/3821214/1ebe4337-f957-4d85-b436-1ece972eca39)

The following is a more obvious extreme example.
![image](https://github.com/KhronosGroup/ToneMapping/assets/3821214/5c02938a-f82d-4d16-a54c-a9432703986a)
![image](https://github.com/KhronosGroup/ToneMapping/assets/3821214/a245528f-7053-40f4-a1f0-23de835e1e88)
![image](https://github.com/KhronosGroup/ToneMapping/assets/3821214/88c64228-21c1-4226-8725-5c9ba0f0e1e6)
![image](https://github.com/KhronosGroup/ToneMapping/assets/3821214/46a3c5b8-4985-4543-a509-015fda2db20e)

I like Khronos PBR Neutral because it preserves saturation very well in general scenes, but this phenomenon is my only concern.

What should I think about this characteristic colour contour in light-filled scenes? (This phenomenon doesn't occur with other tone mappings)

I would be happy to know the appropriate scope and conditions of use of Khronos PBR Neutral.

For reference, my implementation of the Web3D library can be found at the following URL:
https://editor.librn.com/

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reproducing the coloured-contour effect in the linked Web3D library and compare Khronos PBR Neutral with the other tone mappings shown. Review the reported light-filled scenes and determine whether the behaviour is expected; done would be a documented explanation of the scope and conditions of use, or a clearly defined change if it is confirmed as a defect.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
computer-graphics
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.