KhronosGroup / KhronosGroup/SYCL-CTS

`test_vector_operators` does not cover logical and relational operators

Open
#820 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
75
Forks
96
Avg merge
5d 18h
Merged PRs (30d)
4

Description

They are generated as part of the following template:

https://github.com/KhronosGroup/SYCL-CTS/blob/eec8701491114d1930c90679ba5072dd2a5162cb/tests/vector_operators/generate_vector_operators.py#L432

Which is only used by the following function:

https://github.com/KhronosGroup/SYCL-CTS/blob/eec8701491114d1930c90679ba5072dd2a5162cb/tests/vector_operators/generate_vector_operators.py#L1351

Which is in turn never called from anywhere in the generator script, leaving all those operators completely untested by CTS.

Note: I'm actually working on rewriting this particular test to drop python generator script, use `catch2` and improve error messages. This rewrite should fix the problem, but I still wanted to highlight it here. Work-in-progress branch for very early preview can be found here: https://github.com/AlexeySachkov/SYCL-CTS/commits/private/asachkov/refactor-vector-operators-test

Contributor guide

Open the contributing guide

Research direction

Start in tests/vector_operators/generate_vector_operators.py at the referenced template and function, then trace the generator entry points to confirm the logical and relational operators are omitted. Review the linked work-in-progress branch and verify that CTS exercises those operators when the rewrite is complete.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, python
Domain
testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.