KhronosGroup / KhronosGroup/SYCL-CTS
Possible bug in `accessor_legacy` tests
- Dominant language
- C++
- Stars
- 75
- Forks
- 96
- Avg merge
- 5d 18h
- Merged PRs (30d)
- 4
Description
I am currently trying to run the `accessor_legacy` tests with Open SYCL.
The `parallel_for` in [this line](https://github.com/KhronosGroup/SYCL-CTS/blob/SYCL-2020/tests/accessor_legacy/accessor_api_local_common.h#L137) is a `nd_range` `parallel_for`. The kernel is defined [here](https://github.com/KhronosGroup/SYCL-CTS/blob/SYCL-2020/tests/accessor_legacy/accessor_api_common_buffer_local.h#L352) and takes a `sycl_id_t` as its argument which is basically an alias to `sycl::id`. Shouldn't this be a `sycl::nd_item` instead?
I tried to just change it to a `sycl::nd_item` but there are other functions that expect the index to be a `sycl::id` (for instance the function `expected_write` [here](https://github.com/KhronosGroup/SYCL-CTS/blob/SYCL-2020/tests/accessor_legacy/accessor_api_common_buffer_local.h#L576)) and I wanted to make sure that my understanding is correct and that this is a bug before working on this further.
Contributor guide
Assessment
This issue has not been assessed yet.