KhronosGroup / KhronosGroup/SPIRV-Tools

Can we move mimalloc.cpp to a separate directory?

Open
#6,250 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
1.4k
Forks
709
Avg merge
1d 22h
Merged PRs (30d)
28

Description

Looks like mimalloc.cpp was added recently to pull in new and delete symbols. For projects that already depend on mimalloc and pull in these symbols it creates a conflict. A bunch of effort is needed in each build system now to filter out mimalloc.cpp from glob operations. Can we instead move it to its own directory to make filtering it out easier? e.g. sources/mimalloc/mimalloc.cpp or sources/optional/mimalloc.cpp?

Contributor guide

Open the contributing guide

Research direction

Start by locating sources/mimalloc.cpp and the build-system rules or glob operations that include it. Compare the proposed directory locations and trace how the file is selected by each build path. Done means the file is separated as requested and projects using source globs no longer need to filter it out.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
build-system
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.