KhronosGroup / KhronosGroup/SPIRV-Tools
Refactor validator so you can write good unit tests for dominance calculations.
Open
component:general-utility
component:validation
dev:testing
- Dominant language
- C++
- Stars
- 1.4k
- Forks
- 709
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 28
Description
E.g. construct binary module, then compute dominators, then access immediate_dominators for particular blocks.
Contributor guide
Research direction
Start by locating the validator's dominance calculation entry point and any existing tests; the issue names no files or test targets. Review how a binary module is constructed, dominators are computed, and immediate_dominators is accessed for blocks. Done means those steps can be exercised cleanly in focused unit tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100