KhronosGroup / KhronosGroup/SPIRV-Tools
spirv-fuzz: Add missing instructions to InstructionHasNoSideEffects in fuzzerutil
Open
component:fuzzer
- Dominant language
- C++
- Stars
- 1.4k
- Forks
- 709
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 28
Description
The InstructionHasNoSideEffects instruction in fuzzerutil returns true
iff the given instruction has no side effects.
The list is not yet complete.
Notably, GLSL built-in extended instructions (called using OpExtInst)
are not currently considered.
This function was defined in #3667 (which needs to be merged)
Contributor guide
Research direction
Review issue #3667 first, then locate the InstructionHasNoSideEffects entry point in fuzzerutil. Compare its current instruction list with the missing GLSL built-in extended instructions invoked through OpExtInst; done means those relevant instructions are correctly considered and the existing SPIRV-Tools checks pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100