KhronosGroup / KhronosGroup/SPIRV-Tools

Consider banning use of std::queue due to potential slowness with MSVC

Open
#1,176 2 comments 0 reactions 1 assignee Claimed by @alan-baker View on GitHub
component:optimization
Dominant language
C++
Stars
1.4k
Forks
709
Avg merge
1d 22h
Merged PRs (30d)
28

Description

By default std::queue uses a std::deque as the underlying container.

Some past experience with MSVC runtimes have shown that block sizes for std::deqeue could be quite small and you could end up jumping around memory a lot.

Need to investigate!

The optimizer and compressor use std::deque, in possibly performance-critical parts of the code.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.