KhronosGroup / KhronosGroup/SPIRV-Reflect

Fix use of strcat_s when parsing SpvOpSourceContinued

Open
#128 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
871
Forks
188
Avg merge
19m
Merged PRs (30d)
1

Description

When concatenating the source strings while parsing SpvOpSourceContinued, strcat_s is called with a wrong length for the target buffer on Windows. PR #127 is a suggested fix.

Contributor guide

No contributing guide indexed for this repository

Research direction

Locate the code that parses SpvOpSourceContinued and inspect its strcat_s call, using PR #127 as the suggested fix reference. Done means the target-buffer length passed to strcat_s is correct on Windows while concatenating source strings.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
compilers
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.