KhronosGroup / KhronosGroup/SPIRV-LLVM-Translator
[Coverity] Copy instead of move
- Dominant language
- LLVM
- Stars
- 625
- Forks
- 279
- Avg merge
- 3d 5h
- Merged PRs (30d)
- 34
Description
See issues at https://scan.coverity.com/projects/intel-llvm?tab=overview
CID `489856`:
https://github.com/KhronosGroup/SPIRV-LLVM-Translator/blame/590068b12402262dd9bd0aa1386f2e89babfa8a1/lib/SPIRV/SPIRVWriter.cpp#L2430
CID `489869`:
https://github.com/KhronosGroup/SPIRV-LLVM-Translator/blame/590068b12402262dd9bd0aa1386f2e89babfa8a1/lib/SPIRV/SPIRVWriter.cpp#L6425
CID `490409`:
This one looks a bit weird to me, not sure if its a valid hit:
https://github.com/KhronosGroup/SPIRV-LLVM-Translator/blame/590068b12402262dd9bd0aa1386f2e89babfa8a1/lib/SPIRV/SPIRVWriter.cpp#L5148
CID `490034`:
https://github.com/KhronosGroup/SPIRV-LLVM-Translator/blob/590068b12402262dd9bd0aa1386f2e89babfa8a1/lib/SPIRV/libSPIRV/SPIRVEntry.cpp#L637
CID `490504`:
https://github.com/KhronosGroup/SPIRV-LLVM-Translator/blob/590068b12402262dd9bd0aa1386f2e89babfa8a1/lib/SPIRV/libSPIRV/SPIRVInstruction.h#L1197
CID `490545`:
https://github.com/KhronosGroup/SPIRV-LLVM-Translator/blob/590068b12402262dd9bd0aa1386f2e89babfa8a1/lib/SPIRV/libSPIRV/SPIRVInstruction.h#L1804
CID `489914`:
https://github.com/KhronosGroup/SPIRV-LLVM-Translator/blob/590068b12402262dd9bd0aa1386f2e89babfa8a1/lib/SPIRV/libSPIRV/SPIRVModule.cpp#L718
CID `490348`:
https://github.com/KhronosGroup/SPIRV-LLVM-Translator/blob/590068b12402262dd9bd0aa1386f2e89babfa8a1/lib/SPIRV/libSPIRV/SPIRVUtil.h#L164
CID `439509`:
https://github.com/KhronosGroup/SPIRV-LLVM-Translator/blob/590068b12402262dd9bd0aa1386f2e89babfa8a1/lib/SPIRV/libSPIRV/SPIRVUtil.h#L167
CID `489584`:
https://github.com/KhronosGroup/SPIRV-LLVM-Translator/blob/590068b12402262dd9bd0aa1386f2e89babfa8a1/lib/SPIRV/libSPIRV/SPIRVValue.h#L310
Contributor guide
Research direction
Start with the Coverity report and review CIDs 489856, 489869, 490409, 490034, 490504, 490545, 489914, 490348, 439509, and 489584 in the referenced SPIRVWriter.cpp, SPIRVEntry.cpp, SPIRVInstruction.h, SPIRVModule.cpp, SPIRVUtil.h, and SPIRVValue.h locations. Determine which findings are valid and confirm that each valid copy-instead-of-move finding is addressed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100