KhronosGroup / KhronosGroup/SPIRV-LLVM-Translator
proper handling for barrier call attributes
- Dominant language
- LLVM
- Stars
- 625
- Forks
- 279
- Avg merge
- 3d 5h
- Merged PRs (30d)
- 34
Description
The recent PR #1407 fixed barrier call attributes, but only for the conversion from SPIR-V to the OpenCL C 2.0-style LLVM IR. Is the same change also needed for the conversion to the OpenCL C 1.2-style LLVM IR?
Is there a way to write a test to observe the behavior when the barrier call attributes are not handled properly?
I'm also asking this question because it's unclear if I need to add a similar fix for my recent split barrier extension:
* https://github.com/KhronosGroup/SPIRV-LLVM-Translator/pull/1424
Thanks!
Contributor guide
Research direction
Start by reviewing PR #1407 and comparing the SPIR-V-to-OpenCL C 2.0-style and 1.2-style LLVM IR conversion paths. Investigate whether barrier call attributes differ between them, and determine whether a test can expose the incorrect behavior; also consider the related split barrier extension in PR #1424.
Written by the indexing model from the issue text.
Assessment
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100