KhronosGroup / KhronosGroup/SPIRV-LLVM-Translator

Multiple capabilities not mapped to extensions in SPIRVCapability::getRequiredExtension()

Open
#1,052 0 comments 0 reactions 1 assignee Claimed by @MrSidims View on GitHub
Dominant language
LLVM
Stars
625
Forks
279
Avg merge
3d 5h
Merged PRs (30d)
34

Description

Currently, the `SPIRVCapability::getRequiredExtension()` switch only covers a few cases, whereas multiple extension implementations have missed this mapping. TBD:
1. Review the extension/capability list and add the missing tokens into the function body
2. Change the function's switch statement to `switch (static_cast(Kind))` so as to silence warnings for `internal::` capabilities (practically done in https://github.com/KhronosGroup/SPIRV-LLVM-Translator/pull/1053).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.