KhronosGroup / KhronosGroup/SPIRV-Cross

GLSL: Creates unnecesary dummy samplers

Open
#1,737 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
GLSL
Stars
2.5k
Forks
713
Avg merge
2d 18h
Merged PRs (30d)
16

Description

When `OpImageQuerySizeLod` and `OpImageSampleImplicitLod` are used on the same texture a dummy `sampler2D` is created when there is no need to.

Contributor guide

No contributing guide indexed for this repository

Research direction

No file, test, or entry point is named. Start by reproducing the GLSL output for shaders using OpImageQuerySizeLod and OpImageSampleImplicitLod on the same texture, then trace sampler creation in the relevant SPIRV-Cross compiler path; done means the unnecessary dummy sampler is no longer emitted.

Written by the indexing model from the issue text.

Assessment

Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.