KhronosGroup / KhronosGroup/OpenXR-SDK-Source
Windows loader uses dynamic MSVCRT by default
- Dominant language
- Python
- Stars
- 825
- Forks
- 306
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 1
Description
The comments on line 220-221 say one thing but this line is doing something else:
**Edit:** I've read the comment again, it seems to be fine, probably a misunderstanding on my side. However the default build behavior has changed, and we are using a dynamic MSVCRT for the static build. I don't know if this is the right thing to do. Changing the following line from `AND NOT` to `OR NOT` fixed my issue but it's probably the wrong approach.
https://github.com/KhronosGroup/OpenXR-SDK-Source/blob/33c4600cda9cd7689a2452c2251d8e5df0765d0e/src/loader/CMakeLists.txt#L208
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with src/loader/CMakeLists.txt at line 208 and compare its condition with the comments around lines 220-221. Reproduce the Windows static-build configuration, determine whether it selects a dynamic MSVCRT, and verify the corrected behavior with the relevant Windows build.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake
- Domain
- build-system, operating-systems
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100