KhronosGroup / KhronosGroup/OpenCL-SDK

SDK: Overall review comments

Open
#118 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
777
Forks
163
Avg merge
6d 17h
Merged PRs (30d)
2

Description

We tried running the SDK as is and have some comments/ feedback on specific samples. Creating an issue so we can discuss this.

cllayerinfo - No Output from the sample

nbodycpp - Passes but animation does not close
conwaycpp - Passes but animation does not close

saxpy - Fails with:
Verification failed! -9127.552734 != -9127.553711 at index 1
Error: CL_INVALID_VALUE

saxpycpp - Fails with:
Error: Verification FAILED!

For the first two tests, we should perhaps improve the sample to provide meaningful output and to exit cleanly. In general, interested in checking if these samples behave the same on other implementations as well.

Rest of the samples look okay on initial review / run.

General comment that it would be useful for samples to log something to stdout if everything ran successfully,.

Contributor guide

No contributing guide indexed for this repository

Research direction

Run the named samples cllayerinfo, nbodycpp, conwaycpp, saxpy, and saxpycpp to reproduce the reported output, animation, verification, and CL_INVALID_VALUE issues. Compare behavior on other implementations if available; done means the affected samples produce meaningful success output, exit cleanly, and no longer report the listed failures.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.