KhronosGroup / KhronosGroup/OpenCL-CTS

test_multiples uses hard-coded MAX_DEVICES, but passes actual devices count to test_device_set

Open
#931 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
C++
Stars
232
Forks
235
Avg merge
8d 7h
Merged PRs (30d)
18

Description

test_multiples uses hard-coded MAX_DEVICES, but passes actual devices count to test_device_set.
This may fail actual device-count exceeds MAX_DEVICES.
So, either test should dynamically allocate size of device array or cap the number of devices passed to test_device_set to minimum of deviceCount and MAX_DEVICES.
(Although MAX_DEVICES is now reasonably large (32) compared to earlier limit of 8, we can soon exceed MAX_DEVICES for data-center or cloud-based setup and we will have the same problem again)

Contributor guide

No contributing guide indexed for this repository

Research direction

Locate the test_multiples code and the definitions or call sites for MAX_DEVICES and test_device_set. Check how the actual device count is obtained and choose a bounded or dynamically sized device array approach. Done means the test remains safe when the device count exceeds MAX_DEVICES and the relevant OpenCL CTS tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.