KhronosGroup / KhronosGroup/OpenCL-CTS

test_fill_image cts codes don't support embedded profile very well for 1darray or 2darray case

Open
#553 3 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
C++
Stars
232
Forks
235
Avg merge
8d 7h
Merged PRs (30d)
18

Description

In test_fill_1D_array.cpp and test_fill_2D_array.cpp files, to get random image array size, use the following code:
https://github.com/KhronosGroup/OpenCL-CTS/blob/2c0abd3f75d34be97682cd410a1171b87efe964c/test_conformance/images/clFillImage/test_fill_1D_array.cpp#L166
https://github.com/KhronosGroup/OpenCL-CTS/blob/2c0abd3f75d34be97682cd410a1171b87efe964c/test_conformance/images/clFillImage/test_fill_2D_array.cpp#L173
The random generated array size range's min value is fixed to 16. For embedded profile, as the minimum value of CL_DEVICE_IMAGE_MAX_ARRAY_SIZE is 256 in spec. the range's max vlue=256/32=8 which is smaller than 16. So I suggest the min value of random generated array size is set according to device supported maxArraySize instead of a fixed value.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with test_conformance/images/clFillImage/test_fill_1D_array.cpp around line 166 and test_fill_2D_array.cpp around line 173, where the random image array size is generated. Check how the device's supported maximum array size is available, then adjust the random range so embedded-profile devices are covered. Run the relevant clFillImage conformance tests to verify both cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
testing-qa
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.