KhronosGroup / KhronosGroup/GLSL

KHR_vulkan_glsl unused type declaration simplification

Open
#58 2 comments 0 reactions 1 assignee View on GitHub

@johnkslang is already working on this.

Since Aug 19, 2019.

Vulkan
Dominant language
JavaScript
Stars
458
Forks
114
Avg merge
4m
Merged PRs (30d)
1

Description

Many SPIR-V examples in GL_KHR_vulkan_glsl.txt contain fragment that is not used in any of the examples inside the file:

%2 = OpTypeVoid
%3 = OpTypeFunction %2

I can't find reason it was added for. May be it can be removed for clarity?

// Moved from https://github.com/KhronosGroup/Vulkan-Docs/issues/937

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.