KhronosGroup / KhronosGroup/COLLADA2GLTF

Enforcing const methods?

Open
#154 1 comment 0 reactions 0 assignees View on GitHub
discussion
Dominant language
C++
Stars
573
Forks
154
PR merge metrics
No merged PRs in 30d

Description

In the spirit of functional programming and easy reasoning about code, I'm a big fan of marking as much as possible with `const`.

I noticed that almost none of the GLTF methods are const. For example, `TransformMatrix::isIdentity()` is non-const, although it clearly must be. This means that in my own classes, when I have a `const TransformMatrix` variable, I now either have to make a copy, or mark it non-const.

What is your opinion about `const`?

Thanks,
Peter Verswyvelen

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reviewing the existing GLTF methods, especially TransformMatrix::isIdentity(), and inspect the one existing comment for any maintainer decision about const usage. Define which methods can safely be const and the scope of a consistent change; done means the project has an agreed policy and the applicable methods follow it.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
tooling
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.