Khan / Khan/live-editor

CSS comment before @keyframes triggers Oh-Noes

Open
#732 1 comment 2 reactions 0 assignees View on GitHub
bug good first bug webpage
Dominant language
JavaScript
Stars
776
Forks
180
PR merge metrics
No merged PRs in 30d

Description

In the HTML environment, whenever a user properly comments their code before a CSS `@keyframes` rule (or any other at-rule as far as I know) Oh-Noes insists that
`You're missing either a } or another property:value; pair following @keyframes foo`

See [this program](https://www.khanacademy.org/computer-programming/oh-noes-bug/5551285060599808) for an example.

Contributor guide

No contributing guide indexed for this repository

Research direction

Reproduce the issue with the linked Oh-Noes program in the HTML environment, using a comment immediately before a CSS @keyframes rule and checking the reported error. Trace the CSS parsing path that handles comments and at-rules; done means valid commented CSS no longer produces the missing-brace or property:value error.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, javascript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.