Khan / Khan/live-editor

Inconsistent appearances of number scrubber

Open
#543 5 comments 0 reactions 0 assignees View on GitHub
bug editor
Dominant language
JavaScript
Stars
776
Forks
180
PR merge metrics
No merged PRs in 30d

Description

The number scrubber doesn't appear for all numbers, especially if there are certain combinations of letters symbols, or (lack of?) spaces that precede it.

I've documented a whole bunch of possible combinations here. Test by clicking every occurrence of "123" (or scrolling through with arrow keys).
https://www.khanacademy.org/computer-programming/number-scrubber-bug/5383506645876736

It's a little unclear if we want to prevent scrubbing of numbers that are part of variable names, so we should probably settle that before attempting to make a fix (if needed).

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the linked number-scrubber example and reproduce the documented combinations by clicking or navigating through each occurrence of "123". First settle whether numbers inside variable names should be scrubbed; done means the agreed behavior is consistent across the documented cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.