Khan / Khan/live-editor

Yoko Oh Noes should report any content after </body> as an error.

Open
#517 6 comments 0 reactions 0 assignees View on GitHub
idea webpage
Dominant language
JavaScript
Stars
776
Forks
180
PR merge metrics
No merged PRs in 30d

Description

One of the most common issues reported in the HTML/CSS challenges is caused from users creating nodes before or after the `` and `` tags (after being the most common).

It's possible to change each grader to display a message such as:
"It looks like you are trying to place your content after the `` tag. Make sure your content sits between the `` and `` tags."

However this does not prevent the HTML from rendering in the output window, which is what I think is confusing students so much, and it's not valid HTML anyways.

Slowparse should see the following as a syntax error and give an appropriate message.
`node` as well as `node`

All though the examples will technically render in a browser W3C will give, "Error: Non-space character after body." followed by "Fatal Error: Cannot recover after last error. Any further errors will be ignored." when ran through their validator.

To limit user confusion, and to encourage writing valid HTML, this should be seen as an error at KA.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with Slowparse, the parser named in the issue, and trace how content appearing after is handled. The work is done when both examples are reported as syntax errors with an appropriate message instead of rendering as valid output.

Written by the indexing model from the issue text.

Assessment

Tech stack
html, javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.