Khan / Khan/aphrodite

font-face object passed directly doesn't work

Open
#243 6 comments 1 reaction 0 assignees View on GitHub
Dominant language
JavaScript
Stars
5.3k
Forks
187
PR merge metrics
No merged PRs in 30d

Description

I'm on Aphrodite 1.2.1.

I have
```
const Raleway = {
fontFamily: "Raleway",
fontStyle: "normal",
fontWeight: "normal",
src: "url('https://fonts.googleapis.com/css?family=Raleway') format('woff2')",
};
```

This works:
```
const styles = StyleSheet.create({
title: {
fontFamily: [Raleway],
},
});
```

This doesn't:
```
const styles = StyleSheet.create({
title: {
fontFamily: Raleway,
},
});
```

According to the README either one should work:
> "We've made it so that the fontFamily property can accept a font-face object (either directly or inside an array)."

Contributor guide

No contributing guide indexed for this repository

Research direction

Reproduce the two StyleSheet.create examples from the issue using the font-face object and the fontFamily property, and compare them with the README's documented behavior. Trace how Aphrodite handles fontFamily values, then verify that passing the object directly produces the same result as passing it inside an array.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, javascript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.