KavrakiLab / KavrakiLab/Spec2Mol

Predicted embds

Open
#3 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
30
Forks
15
PR merge metrics
No merged PRs in 30d

Description

Hi,

in predict_embs.py file, there are several unnecessary empty lines causing the indent error. They can be deleted as follows::

if __name__ == '__main__':
parser = argparse.ArgumentParser()
parser.add_argument('-pos_low_file', type=str, default=None, help='csv file with positive mode [M+H]+ low energy spectrum')
parser.add_argument('-pos_high_file', type=str, default=None, help='csv file with positive mode [M+H]+ high energy spectrum')
parser.add_argument('-neg_low_file', type=str, default=None, help='csv file with positive mode [M-H]+ low energy spectrum')
parser.add_argument('-neg_high_file', type=str, default=None, help='csv file with positive mode [M-H]- low energy spectrum')
args = parser.parse_args()
main(args)

In addition, a command for saving pre_emb is missing in predict_embs.py (e.g. torch.save(pred_emb, 'sample_my.pt')).

Finally, it would be very helpful to write a wrapper to couple the embs predictor with the decoder and to add an automatic setting of the unknown keys when processing the example input data.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.