Kaszanas / Kaszanas/pysc2_evolved
shuffle_unit_tags expects an integer, but used as a boolean
- Dominant language
- Python
- Stars
- 3
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Description
code from unplugged https://github.com/google-deepmind/alphastar/blob/main/alphastar/unplugged/configs/alphastar_supervised.py:
```python
def get_converter_settings(
use_supervised: bool,) -> converter_pb2.ConverterSettings:
return converter_pb2.ConverterSettings(
raw_settings=converter_pb2.ConverterSettings.RawSettings(
resolution=common_pb2.Size2DI(x=_WORLD_DIM, y=_WORLD_DIM),
max_unit_count=512,
num_unit_features=_NUM_UNIT_FEATURES,
max_unit_selection_size=_MAX_NUM_SELECTED_UNITS,
shuffle_unit_tags=True,
enable_action_repeat=True,
use_camera_position=_USE_CAMERA,
camera=_USE_CAMERA,
use_virtual_camera=_USE_CAMERA,
virtual_camera_dimensions=converter_pb2.ConverterSettings.RawSettings
.CameraDimensions(left=16, right=16, top=13, bottom=7),
add_effects_to_units=True,
add_cargo_to_units=True,
mask_offscreen_enemies=_USE_CAMERA),
minimap=common_pb2.Size2DI(x=_MINIMAP_DIM, y=_MINIMAP_DIM),
minimap_features=[
"height_map", "visibility_map", "creep", "player_relative", "alerts",
"pathable", "buildable"
],
num_action_types=NUM_RAW_FUNCTIONS,
num_unit_types=NUM_UNIT_TYPES,
num_upgrade_types=_NUM_UPGRADES,
max_num_upgrades=40,
camera_width_world_units=24,
mmr=6000,
supervised=use_supervised,
crop_to_playable_area=False)
```
Shuffle unit tags is set to True, in the converter code it is also used as a boolean but someone messed up when defining the proto and didn't think to adjust it.
.pbtxt configuration from unplugged correctly marks it as:
```
max_unit_selection_size: 64
shuffle_unit_tags: 1
enable_action_repeat: true
```
.proto should be adjusted and re-built.
Contributor guide
Assessment
This issue has not been assessed yet.