Kaszanas / Kaszanas/SnapSC2

Processing Fails When Observing Replays From Varying Game Versions

Open
#35 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
1
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Observing replays from multiple game versions at once causes an error where laucher cannot play them stating that the "game is busy".

This results in many failed attempts at loading replays that could work.

The replays should be sorted by game version before being processed.

Only replays from the same version should be processed at the same time.

This can be done in multiple ways.

1. Simplest: sort replaypacks and replays into directories by version
2. Harder: When preparing the arguments for replay processing, instead of creating a list of arguments, create a dictionary of arguments, go over all of the keys in the dictionary, only after the entire collection from one of the keys will be processed start processing another dictionary key. This should force the system to only processed the same game versions.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.