Kaszanas / Kaszanas/SC2Tools

The summarising functionality for continuous variables in `output/sc2egset_replaypack_processor/XXX/XXX_summary.json` is weird

Open
#9 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
TeX
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

A very minor suggestion - the summary json correctly summarises discrete variables like matchups by counts of the individual categories. However, it does the same with continuous variables like `gameTimes`, where each value is unique, so the JSON has stuff like:

```
"gameTimes":{"1000.044643":1,"1006.339286":1,"1010.580357":1,"1023.303571":1,"1028.169643":1,"1032.946429":1,"1033.973214":1,"1041.741071":1,"1046.562500":1,"1064.196429":1,"1081.651786":1,"1084.151786":1,"1105.580357":1,"1149.732143":1,"1157.946429":1,"1159.241071":1,"1195.892857":1,"1196.428571":1,"1196.473214":1,"1200.491071":1,"1206.696429":1,"1225.982143":1,"1229.062500":1,"1255.178571":1,"1272.187500":1,"1272.589286":1,"1279.062500":1,"1282.991071":1,"1332.857143":1,"1381.116071":1,"1402.723214":1,"141.517857":1,"1422.812500":1,"1428.080357":1,"1434.017857":1,"1447.678571":1,"1453.348214":1,"1506.607143":1,"1506.651786":1,"1533.035714":1,"1554.866071":1,"1567.232143":1,"1645.089286":1,"1686.517857":1,"1689.107143":1,"1696.383929":1,"1705.267857":1,"1737.544643":1,"1810.267857":1,"191.339286":1,
....
```

It would probably make more sense to summarise with something like mean, sd and range (or just not summarise at all).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.