Kaggle / Kaggle/learntools

"Frequency" used in place of "phase" in Seasonality tutorial

Open
#468 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
514
Forks
274
PR merge metrics
No merged PRs in 30d

Description

In the `fourier_features()` example algorithm on the Seasonality lesson of the Time Series course, the variable name `freq` is given to a parameter which takes units of days/cycle. This was confusing to me at first, because unless I'm mistaken, frequency typically refers to measurements given in inverse units (cycles/day), whereas period refers to time per cycle.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.