JupiterBroadcasting / JupiterBroadcasting/jupiterbroadcasting.com

Sponsors Page Enhancements

Open
#474 0 comments 1 reaction 0 assignees View on GitHub
enhancement
Dominant language
Sass
Stars
103
Forks
49
Avg merge
3h 42m
Merged PRs (30d)
20

Description

> ### Downside to automation
>
> So, one of the biggest downsides of using the automation is not being able to make small tweaks in verbiage like how @gerbrent just did with #447.
>
> I personally don't think that's an issue as long as
> 1) the JB ads (that are published) are worded in ways that work with the website in mind
> 2) the scraper always updates the ad with the latest version.
>
> #### Situation 1 issues
>
> current issues (left side is this PR & right side (if applicable) is main website :
>
> - [ ] For right now the podcast episodes for LUP ([example](https://linuxunplugged.com/478)) don't point to the right place (according to [447](https://github.com/JupiterBroadcasting/jupiterbroadcasting.com/pull/447/files#diff-c3bdb6a3a90d1cf9f2432854d1c9818e624f04296b2f2e033ba0795422c370c8R14-R19))
> - currently this PR would be a partial regression of #447 since it's pointing to just tailscale.com.
> - [x] Another small thing would be you can't [add comments with MD](https://github.com/JupiterBroadcasting/jupiterbroadcasting.com/pull/447/files#diff-c3bdb6a3a90d1cf9f2432854d1c9818e624f04296b2f2e033ba0795422c370c8R18)
> - I don't think this is bad, just something of note
> - [ ] might have to "blacklist certain sponsors since Office Hours uses jupiter.party as a sponsor which is not currently listed:
![image](https://user-images.githubusercontent.com/10230166/194727211-e20e9517-af00-4fbf-83b5-c436567568df.png)
> - also, slight side-note the title case is weird if `www` in-front (which a future sponsor might have)
> - [ ] Different name in episodes than typically/currently used (Linode vs Linode Cloud Hosting (e.g. [episode](https://linuxunplugged.com/478))):
> ![image](https://user-images.githubusercontent.com/10230166/194727377-a5b8bd99-de68-432e-830b-53864ae01bff.png)
> - [x] Duplication of sponsor name in description, which is an example of how JB's currently only thinking of what looks good on the episode pages for ads (could probably be tweaked for website):
> ![image](https://user-images.githubusercontent.com/10230166/194727565-a54267e5-14b6-423c-a189-afe59edd208b.png)
> - fixed with: https://github.com/JupiterBroadcasting/jupiterbroadcasting.com/pull/451/commits/cefc68219cf1c7dbd0269a6be4f4db8ee8a3d0ea
>
> #### Situation 2 issues
>
> Currently it's a known issue (but I don't think it's documented anywhere) that a sponsor's description could change between scraper runs. This is because the scraper will select the first episode it can parse which isn't already added to the `SPONSOR` global variable for the corresponding show (logic is [here](https://github.com/JupiterBroadcasting/show-scraper/blob/48f0833e63a8473eb8afa6d2297942aeb487b139/scraper.py#L331)).
>
> If we were able to pull the most recent episode it would negate the largest overall issue, because then JB could update their ad and it would reflect on the website (technically only for the most 5 recent episodes though with our current setup).
>
> I've added this issue/situation to my tasks listed in https://github.com/JupiterBroadcasting/show-scraper/issues/20 as an OOP enhancement, because we'd be able to prevent this if we could say "only use the most recent sponsor's description" instead of leaving it to chance. This doesn't _technically_ currently affect us at all because the sponsor content isn't overwritten if it already exists (since we're doing the `LASTEST_ONLY` environment variable for the GH action in this repo).
>
> ---
>
> ### small aesthetic stuff
>
> inconsistent `{{-` or `-}}`, intentional?
>
> delete all the content from `_index.md`
>
> Lose a bit of spacing that I personally liked to structure the hierarchy of the page (not a designer though :upside_down_face:)
> ![image](https://user-images.githubusercontent.com/10230166/194726218-0b1e4159-5a6a-4e3d-b56f-c4e607549006.png)
>
> ---
>
> Other info:
>
> - Currently there is an out of date sponsor (on the main JB.com), and in this case the link still works (other future sponsors it might not), but this PR would remove that link.
> ![image](https://user-images.githubusercontent.com/10230166/194727434-28f15d02-1d90-400e-b8e9-fd43801314b2.png)

_Originally posted by @elreydetoda in https://github.com/JupiterBroadcasting/jupiterbroadcasting.com/pull/451#pullrequestreview-1135262770_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.