JupiterBroadcasting / JupiterBroadcasting/jupiterbroadcasting.com

Scraper only commits to main

Open
#444 10 comments 1 reaction 0 assignees View on GitHub
dev enhancement feedback requested
Dominant language
Sass
Stars
103
Forks
49
Avg merge
3h 42m
Merged PRs (30d)
20

Description

Currently the scraper only commits new episodes to `main` via the GitHub Action. I think we need the episodes to go into `develop` and `main`. I am drafting a [PR](https://github.com/JupiterBroadcasting/jupiterbroadcasting.com/pull/443) and it would commit the 3 missing episodes to develop and I am not sure if this will cause issues when `develop` is merged into `main` in the future.

I am aware that this only affects contributors that forked the repo *before* the switch of `develop` being the main branch, but it is still something we need to think about.

My guess would be
1. We update the action to commit to both `develop` and `main`
* I'm not 100% sure about this one because I think that this could cause merge conflicts even if the commits are identical (not sure if git/GitHub is smart enough to see they are the same commit)
2. We could make a branch for the scraped data and automatically create/merge PRs for both `develop` and `main`
* It sounds a bit complicated, but it should relieve the concern I have about in idea 1

Definitely looking for some ideas on this one...

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.