JupiterBroadcasting / JupiterBroadcasting/jupiterbroadcasting.com

IRC - code duplication to be consolidated

Open
#255 0 comments 0 reactions 0 assignees View on GitHub
enhancement low priority
Dominant language
Sass
Stars
103
Forks
49
Avg merge
3h 42m
Merged PRs (30d)
20

Description

We will now have IRC information listed in two places:

* [./community/irc.md](https://github.com/JupiterBroadcasting/jupiterbroadcasting.com/blob/main/content/community/irc.md)
* https://jb-live.jupiterbroadcasting.net/ - [./config.jblive.toml](https://github.com/JupiterBroadcasting/jupiterbroadcasting.com/blob/main/config.jblive.toml)

I wonder if we could also consider the Hugo principle of "everything only exists once" ?

_Originally posted by @reclaimingmytime in [#253](https://github.com/JupiterBroadcasting/jupiterbroadcasting.com/issues/253#issuecomment-1209623411_):
> @gerbrent Good point! I agree a general goal is to avoid code duplication, in this case, using Hugo variables for the IRC server, channel and default username and extracting the "prefer your own IRC client?" box to a partial. If the server address changes, it only has to be modified once.
>
> Maybe this can be part of JB 2.0.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.