JuliaWeb / JuliaWeb/RemoteREPL.jl

returning `Connection`

Open
#56 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Julia
Stars
145
Forks
17
PR merge metrics
No merged PRs in 30d

Description

Currently `remote_repl` returns a connection and writes to the global `_repl_client_connection`.

And `connect_repl` doesn't return a connection but also writes to the global `_repl_client_connection`.

I find this behavior inconsistent. Is it necessary that `connect_repl` returns the `ReplMaker` `prompt` ?
In any case, I think it would be nice to also return the `Connection`.
This way the client can always have a way of closing the connection. (without having to access the global `_repl_client_connection`)
Aside from that, this could also enable handling multiple connections.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.