JuliaWeb / JuliaWeb/GitHub.jl

Use `Base.SecretBuffer` instead of `String` inside OAuth2?

Open
#142 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Julia
Stars
175
Forks
62
PR merge metrics
No merged PRs in 30d

Description

Currently, the definition of OAuth2 is: (see src/utils/auth.jl)

struct OAuth2 <: Authorization
    token::String
end

Should token be a Base.SecretBuffer instead of a String?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read src/utils/auth.jl and inspect the OAuth2 definition and its token field. Determine whether changing the stored token type to Base.SecretBuffer is appropriate for this authorization model, including any affected construction or use sites; done means reaching and documenting a clear decision with coverage for the resulting behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
authentication, security
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.