JuliaSmoothOptimizers / JuliaSmoothOptimizers/RegularizedOptimization.jl

TRDH check for subsolver is not robust

Open
#303 0 comments 0 reactions 1 assignee Claimed by @MaxenceGollier View on GitHub
invalid
Dominant language
Julia
Stars
21
Forks
11
PR merge metrics
No merged PRs in 30d

Description

Checking if the solver is being used as a subsolver like so i odd.

https://github.com/JuliaSmoothOptimizers/RegularizedOptimization.jl/blob/8b7a6b78eec80e5533c5f357d815cb749c90394a/src/TRDH_alg.jl#L49

It would be easier just to add a kwarg to the solver constructor that is set to false and set it to true when constructing it with other solvers. The user would never need to change the value of this kwarg.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.