JuliaSmoothOptimizers / JuliaSmoothOptimizers/BundleAdjustmentModels.jl

NLSModels API

Open
#39 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
Julia
Stars
9
Forks
7
PR merge metrics
No merged PRs in 30d

Description

Thanks @AntoninKns for this great repo!

I was checking the `BundleAdjustmentModel`, which follows the NLSModel API, and I have a couple of comments:
- I think the jacobian of the residual should be described by `jac_structure_residual!` and `jac_coord_residual!` and not `jac_structure!` [L.159](https://github.com/JuliaSmoothOptimizers/BundleAdjustmentModels.jl/blob/1c3ebab429933a2c21da586b735d6c2ef018d22f/src/BundleAdjustmentNLSFunctions.jl#L159) and `jac_coord!` [L.196](https://github.com/JuliaSmoothOptimizers/BundleAdjustmentModels.jl/blob/1c3ebab429933a2c21da586b735d6c2ef018d22f/src/BundleAdjustmentNLSFunctions.jl#L196).
- Adding the functions `jprod_residual!`, and `jtprod_residual!` would be very useful.
- I might have missed it, but it could be useful to add somewhere in the documentation that the `BundleAdjustmentModel` doesn't return any second-order information on the residual.
- Finally, I believe the docstring of `BundleAdjustmentModel` [L.5](https://github.com/JuliaSmoothOptimizers/BundleAdjustmentModels.jl/blob/1c3ebab429933a2c21da586b735d6c2ef018d22f/src/BundleAdjustmentNLSFunctions.jl#L5) might be misleading since the model is a nonlinear least-square optimization problem.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.