JuliaPhysics / JuliaPhysics/Unitful.jl

Default `isapprox()` definition differs from Base julia

Open
#710 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Julia
Stars
675
Forks
124
Avg merge
3h 38m
Merged PRs (30d)
1

Description

The `isapprox()` definition in this package does not match that of Julia's, causing differences when units are applied versus when they are not:

```
x = 1.0u"s"
y = 1.0u"s" + 1e-4u"s"

@show isapprox(x, y; rtol=1e-4)
@show isapprox(ustrip(x), y; rtol=1e-4)
@show isapprox(x, ustrip(y); rtol=1e-4)
@show isapprox(ustrip(x), ustrip(y); rtol=1e-4)
```

Yields:

```
isapprox(x, y; rtol = 0.0001) = true
isapprox(ustrip(x), y; rtol = 0.0001) = false
isapprox(x, ustrip(y); rtol = 0.0001) = false
isapprox(ustrip(x), ustrip(y); rtol = 0.0001) = true
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.