JuliaPhysics / JuliaPhysics/RadiationDetectorSignals.jl
Numerical Problems with `UInt` waveforms
- Dominant language
- Julia
- Stars
- 6
- Forks
- 4
- Avg merge
- 4h 12m
- Merged PRs (30d)
- 3
Description
In case you are loading a `RDWaveform` which consists of `Integers`, most filter code in `RadiationDetectorDSP` fails because it wants to return `Int` types for each sample after the filter is applied.
So far, we convert the waveforms by something like this:
``` julia
wvfs = shift_waveform.(wvfs, 0.0)
```
There should be a more elegant solution than this.
CC @fhagemann
Contributor guide
No contributing guide indexed for this repository
Research direction
No file, test, or entry point is named. Start by locating RDWaveform and the filter code in RadiationDetectorDSP, then reproduce the failure with an integer-valued waveform; done means the filters handle UInt waveforms without requiring shift_waveform.(wvfs, 0.0).
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- data
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100