JuliaParallel / JuliaParallel/Dagger.jl

Fix `mapchunks` and write Test for it

Open
#476 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Julia
Stars
723
Forks
90
Avg merge
1d 37m
Merged PRs (30d)
9

Description

While looking for a way to flatten an DArray, I found `mapchunks`, which looks perfectly suited for this job. Unfortunately it is currently buggy. Probably because there is no test for it.

https://github.com/JuliaParallel/Dagger.jl/blob/cec17a14f75523bdcae3a6b00ede6c22d1d0fe9f/src/array/darray.jl#L387-L393

The DArray constructor used here does not exist any longer. There is a new argument - the partitioning - which need to be added.

```diff
- DArray{T,N,F}(d.domain, d.subdomains, chunks, d.concat)
+ DArray{T,N}(d.domain, d.subdomains, chunks, d.partitioning, d.concat)
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.