JuliaMath / JuliaMath/openlibm

Sync patches from upstream (BSD)

Open
#320 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
632
Forks
163
Avg merge
4m
Merged PRs (30d)
1

Description

- [x] #222
- [x] https://github.com/JuliaMath/openlibm/pull/319#issuecomment-2592194108

diff: https://github.com/inkydragon/openlibm/commit/08774892228efb09f305ab9bb370c55f7845965b

> Do we want to sync `openlibm_fenv_arm.h` from FreeBSD too?
>
> Seems there are some bugs:
>
> https://github.com/JuliaMath/openlibm/blob/5a88ede059eab2c651a3c1589aabe85136ea9a48/include/openlibm_fenv_arm.h#L65-L67
>
> ```c
> /* We need to be able to map status flag positions to mask flag positions */
> #ifndef __ARM_PCS_VFP
> #define _FPUSW_SHIFT 16
> #define _ENABLE_MASK (FE_ALL_EXCEPT << _FPUSW_SHIFT)
> #endif
> ```
>
> And FreeBSD doesn't use `_ENABLE_MASK` [freebsd/freebsd-src@`de1aa3d`/lib/msun/arm/fenv.h#L83-L87](https://github.com/freebsd/freebsd-src/blob/de1aa3dab23c06fec962a14da3e7b4755c5880cf/lib/msun/arm/fenv.h#L83-L87)
>
> ```c
> #else /* __ARM_PCS_VFP */
>
> ...
>
> #define _FPU_MASK_SHIFT 8
> ```
>
> [freebsd/freebsd-src@`de1aa3d`/lib/msun/arm/fenv.h#L113](https://github.com/freebsd/freebsd-src/blob/de1aa3dab23c06fec962a14da3e7b4755c5880cf/lib/msun/arm/fenv.h#L113)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.