JuliaMath / JuliaMath/Roots.jl

bracketing methods with CommonSolve interface

Open
#452 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Julia
Stars
413
Forks
61
Avg merge
57m
Merged PRs (30d)
5

Description

the CommonSolve interface mentions:
> The problem-algorithm-solve interface is a pattern popularized in Julia by the DifferentialEquations.jl suite of packages. This can be used as an alternative to find_zero. Unlike find_zero, solve will return NaN on non-convergence.

But, for bracketing methods, the function `Roots.assert_bracket` throws:
https://github.com/JuliaMath/Roots.jl/blob/18354b00d1796af86f760943476471d4afe67f56/src/Bracketing/bracketing.jl#L52

The error path for `assert_bracket`. also gets activated when one of the values is NaN, instead of returning NaN.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.