JuliaMath / JuliaMath/GSL.jl

`custom_error_handler` needs redesign

Open
#84 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Julia
Stars
101
Forks
30
PR merge metrics
No merged PRs in 30d

Description

While trying the reproduce the issue reported in #63 I've noted that `custom_error_handler` needs a redesign. This is its current signature:
```julia
custom_error_handler(reason::AbstractString, file::AbstractString, line::Integer, errno::Integer)
```
but some of the errors to be thrown needs more information, like `DomainError()`. BTW, `custom_error_handler` is actually never used directly but always through `GSL_ERROR`, which hides all arguments but `errno`. Thus, probably also `GLS_ERROR` needs some redesign.

PS: as a general comment, this package really needs some serious improvement in test coverage. There are really old cruft in the code, like calls to `Compat.@dep_vectorize_2arg`, I'm even surprised this macro is still in `Compat`.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.