JuliaMath / JuliaMath/AbstractFFTs.jl

Define FFT planning flags independent from FFTW

Open
#71 2 comments 3 reactions 0 assignees View on GitHub
Dominant language
Julia
Stars
134
Forks
40
PR merge metrics
No merged PRs in 30d

Description

The FFT planning functions, `plan_fft` et al., accept a keyword argument `flags` that is used to provide options to the planning function of the FFT implementation. The `flags` argument is [currently documented](https://juliamath.github.io/AbstractFFTs.jl/stable/api/#AbstractFFTs.plan_fft) to be "a bitwise-or of FFTW planner flags". This effectively creates a documented dependency on FFTW, even though FFTW is not a dependency of AbstractFFTs (in fact it's the other way around). It would be preferable to have AbstractFFTs define any and all flags that FFT planners may wish to use and then have FFT implementations, such as FFTW, adapt the flags from AbstractFFTs values to suitable values for use with the underlying implementation as they see fit.

For an example of why the current approach is problematic, see https://github.com/JuliaGPU/CUDA.jl/issues/1559

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.