JuliaMath / JuliaMath/AbstractFFTs.jl

Separate types for rFFT and FFT plans (and issues with ScaledPlans)

Open
#63 6 comments 0 reactions 0 assignees View on GitHub
Dominant language
Julia
Stars
134
Forks
40
PR merge metrics
No merged PRs in 30d

Description

Since PR https://github.com/JuliaMath/AbstractFFTs.jl/pull/58 is now merged, I would suggest talking about how to extend this to `Plans` as well.

One way of doing that would be to implement different (abstract) types for a FFT, rFFT and r2r. This of course would have some implications for the libraries relying on AbstractFFTs. That's why I did not directly proceed with a PR, but would want to discuss this first.

Something reasonable could be to have an `AbstractFFTPlan`, `AbstractrFFTPlan`, `AbstractR2RPlan` that are all subtypes of the current `Plan` type, so that it is not a completely breaking change. (Ideally Plan should be renamed to AbstractPlan, but this would break a lot, I guess)

Aside from this, there is also https://github.com/JuliaMath/FFTW.jl/issues/182 , so that ScaledPlans miss the `region` subfield, which could be mitigated by a function like

```Julia
region(p::Plan) = p.region
region(p::ScaledPlan) = region(p.p)
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.