JuliaMath / JuliaMath/AbstractFFTs.jl

`lmul!` should be required for in-place application of plans

Open
#18 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Julia
Stars
134
Forks
40
PR merge metrics
No merged PRs in 30d

Description

This is basically the same issue/suggestion as https://github.com/JuliaMath/FFTW.jl/issues/77. In my opinion, it would make sense to apply in-place plans with `lmul!` already in the generic implementation of `fft!`, `bfft!`, and `ifft!` in https://github.com/JuliaMath/AbstractFFTs.jl/blob/master/src/definitions.jl#L50-L52.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with src/definitions.jl at lines 50-52, where the generic fft!, bfft!, and ifft! implementations are defined. Read the related FFTW.jl issue linked in the report to understand the intended in-place plan behavior; done means those generic implementations require lmul! for applying in-place plans.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
backend-api-design
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.